Shutdown the executor service in KubernetesApplicationOperation and prevent NPE #6785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turboFei
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6785 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 687 687
Lines 42439 42447 +8
Branches 5793 5796 +3
======================================
- Misses 42439 42447 +8 ☔ View full report in Codecov by Sentry. |
wForget
reviewed
Nov 1, 2024
| @@ -273,6 +274,16 @@ class KubernetesApplicationOperation extends ApplicationOperation with Logging { | |||
| Utils.tryLogNonFatalError(client.close()) | |||
| } | |||
| kubernetesClients.clear() | |||
|
|
|||
| if (expireCleanUpTriggerCacheExecutor != null) { | |||
There was a problem hiding this comment.
This may need to be placed before assigning cleanupTerminatedAppInfoTrigger to null.
There was a problem hiding this comment.
No, we need to invalidate the cache before shutdown the executor.
There was a problem hiding this comment.
So that, the remaining terminated application can be cleaned before server stop.
There was a problem hiding this comment.
The non-null check here is not atomic, so NPE may still occur.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Description
Issue References 🔗
As title.
Fix NPE, because the cleanupTerminatedAppInfoTrigger will be set to
null.kyuubi/kyuubi-server/src/main/scala/org/apache/kyuubi/engine/KubernetesApplicationOperation.scala
Line 269 in d3520dd
Also shutdown the ExecutorService when KubernetesApplicationOperation stoped.
Describe Your Solution 🔧
Shutdown the thread executor service and check the null.
Types of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
Behavior With This Pull Request 🎉
Related Unit Tests
Checklist 📝
Be nice. Be informative.